linux-kernel - Re: [PATCH v2] dt-bindings: dsp: mediatek: add mt8195 dsp document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfb2d2f7-06fc-5930-4d24-b51e8b69c9bd@intel.com>
Date:   Fri, 17 Dec 2021 12:05:03 +0100
From:   Cezary Rojewski <cezary.rojewski@...el.com>
To:     YC Hung <yc.hung@...iatek.com>, <broonie@...nel.org>,
        <tiwai@...e.com>, <robh+dt@...nel.org>, <matthias.bgg@...il.com>
CC:     <alsa-devel@...a-project.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <daniel.baluta@....com>, <trevor.wu@...iatek.com>,
        <allen-kh.cheng@...iatek.com>
Subject: Re: [PATCH v2] dt-bindings: dsp: mediatek: add mt8195 dsp document

On 2021-12-17 8:08 AM, YC Hung wrote:
> From: "yc.hung" <yc.hung@...iatek.com>
> 
> This patch adds mt8195 dsp document.

Hello,

While above statement is correct, the commit message would probably 
benefit if expanded a bit. Don't get me wrong, I also find describing 
rather obvious changes problematic.

Here, stating what 'mt8195 dsp' is and what's use, even in a single 
sentence, would probably do the job.


Regards,
Czarek

> Signed-off-by: yc.hung <yc.hung@...iatek.com>
> ---
> Changes since v1:
>    Rename yaml file name as mediatek,mt8195-dsp.yaml
>    Refine descriptions for mailbox, memory-region and drop unused labels
>    in examples.