linux-kernel - Re: [PATCH v2 36/37] drm/tilcdc: Add support for the nomodeset kernel parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e12f51baaf76b9863b4ab11fdb86af6@iki.fi>
Date:   Fri, 17 Dec 2021 15:30:02 +0200
From:   Jyri Sarha <jyri.sarha@....fi>
To:     Javier Martinez Canillas <javierm@...hat.com>
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Tomi Valkeinen <tomba@...nel.org>
Subject: Re: [PATCH v2 36/37] drm/tilcdc: Add support for the nomodeset kernel
 parameter

On 2021-12-17 2:37, Javier Martinez Canillas wrote:
> According to disable Documentation/admin-guide/kernel-parameters.txt, 
> this
> parameter can be used to disable kernel modesetting.
> 
> DRM drivers will not perform display-mode changes or accelerated 
> rendering
> and only the system framebuffer will be available if it was set-up.
> 
> But only a few DRM drivers currently check for nomodeset, make this 
> driver
> to also support the command line parameter.
> 
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>

Acked-by: Jyri Sarha <jyri.sarha@....fi>

> ---
> 
> (no changes since v1)
> 
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index cc567c87057d..eee3c447fbac 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -604,6 +604,9 @@ static struct platform_driver 
> tilcdc_platform_driver = {
> 
>  static int __init tilcdc_drm_init(void)
>  {
> +	if (drm_firmware_drivers_only())
> +		return -ENODEV;
> +
>  	DBG("init");
>  	tilcdc_panel_init();
>  	return platform_driver_register(&tilcdc_platform_driver);