linux-kernel - Re: [PATCH v2 1/5] dt-bindings: interrupt-controller: Update STM32 EXTI interrupt controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f8acbb8-0b7e-2f47-eefc-67e5a7632445@foss.st.com>
Date:   Fri, 17 Dec 2021 14:39:11 +0100
From:   Alexandre TORGUE <alexandre.torgue@...s.st.com>
To:     Rob Herring <robh@...nel.org>, Marc Zyngier <maz@...nel.org>
CC:     Thomas Gleixner <tglx@...utronix.de>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 1/5] dt-bindings: interrupt-controller: Update STM32
 EXTI interrupt controller

On 12/16/21 9:15 PM, Rob Herring wrote:
> On Wed, Dec 15, 2021 at 11:58:43AM +0100, Alexandre Torgue wrote:
>> Document new entry "st,exti-mapping" which links EXTI lines with GIC
>> interrupt lines and add an include file to define EXTI interrupt type.
>>
>> Signed-off-by: Alexandre Torgue <alexandre.torgue@...s.st.com>
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/st,stm32-exti.yaml b/Documentation/devicetree/bindings/interrupt-controller/st,stm32-exti.yaml
>> index d19c881b4abc..e08bb51e97a8 100644
>> --- a/Documentation/devicetree/bindings/interrupt-controller/st,stm32-exti.yaml
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/st,stm32-exti.yaml
>> @@ -41,6 +41,17 @@ properties:
>>       description:
>>         Interrupts references to primary interrupt controller
>>   
>> +  st,exti-mapping:
>> +    $ref: "/schemas/types.yaml#/definitions/uint32-matrix"
>> +    description: |
>> +            Define mapping between EXTI lines and GIC irq lines. Should be:
>> +            st,exti-mapping = <EXTI_LINE GIC_IRQ EXTI_TYPE>, ...;
>> +            With:
>> +            - EXTI_LINE: EXTI line number.
>> +            - GIC_IRQ: GIC IRQ associated to the EXTI line.
>> +            - EXTI_TYPE: STM32_EXTI_TYPE_CONFIGURABLE or STM32_EXTI_TYPE_DIRECT.
>> +              Defined in include/dt-bindings/interrupt-controller/stm32-exti.h
> 
> No custom properties for this. See[1][2][3].
> 

Thanks for inputs. In my case the mapping consists to map an EXTI line 
with a GIC irq line which could be done using interrupt-map (avoiding to 
parse it in my driver). But for each EXTI/GIC association I would like 
also to describe the EXTI_TYPE (which actually describe the well irqchip 
to use inside my exti driver) . This property is not generic and so I 
assume I can't use a generic binding such "interrupt-map".

If the solution consists to use a common binding (i.e. interrupt-map) 
plus a conversion table in exti driver to affect the well irq_chip to 
the well EXTI line then we could envisage to keep the whole mapping 
inside the driver (even if it's not the best solution).

Another solution could be to define two exti irq-controllers (one for 
configurable type and another one for direct type) and use interrupt-map 
inside each. It means to have 2 child node inside (one per irq 
controller) EXTI node.

Alex


> Rob
> 
> 
> [1] https://lore.kernel.org/all/20211122103032.517923-1-maz@kernel.org/
> [2] https://lore.kernel.org/all/87k0g8jlmg.wl-maz@kernel.org/
> [3] https://lore.kernel.org/all/CAL_JsqK2Shj6smam7HgNAmy3UG+vVQPkU3Q0OjyEHOEJB45n0A@mail.gmail.com/
>