linux-kernel - Re: [PATCH 2/2] dt-bindings: usb: document snps,dis_split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211217144709.7194-1-akingchen@vivo.com>
Date:   Fri, 17 Dec 2021 22:47:09 +0800
From:   Yaqin Pan <akingchen@...o.com>
To:     robh@...nel.org
Cc:     akingchen@...o.com, balbi@...nel.org, devicetree@...r.kernel.org,
        gregkh@...uxfoundation.org, kernel@...o.com,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        s.shtylyov@....ru
Subject: Re: [PATCH 2/2] dt-bindings: usb: document snps,dis_split_quirk property in dwc3

>> >> Add snps,dis_split_quirk property for dwc3 controller
>> >>
>> >> Signed-off-by: Yaqin Pan <akingchen@...o.com>
>> >> ---
>> >>   Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 ++++++
>> >>   1 file changed, 6 insertions(+)
>> >>
>> >> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> >> index 41416fbd92aa..e9615ca8f447 100644
>> >> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> >> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> >> @@ -226,6 +226,12 @@ properties:
>> >>         avoid -EPROTO errors with usbhid on some devices (Hikey 970).
>> >>       type: boolean
>> >>   +  snps,dis_split_quirk:
>
>I'm tired of the never ending DWC3 quirks. Imply this from the 
>compatible unless it varies by board.

Yes, this is a DWC3 controller compatible issue.

>
>Also, don't use '_' in DT names.

Sure, i will change "snps,dis_split_quirk" to "snps,dis-split-quirk".

>
>> >> +    description:
>> >> +      When set, change the way host controller schedules transations for a Control transfer.
>> > 
>> >    Transactions.
>> > 
>> >> +      Needed to avoid emurate some devices fail.
>> > 
>> >    Avoid failing to enumerating some devices?

Yes. Avoid failing to enumerate some devices.

>> 
>>    Sorry. enumarate. :-)

> Or enumerate