linux-kernel - Re: [PATCH] isoc: mediatek: Fix dereference of null pointer while alloc fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Dec 2021 16:13:30 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     matthias.bgg@...il.com, lgirdwood@...il.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] isoc: mediatek: Fix dereference of null pointer while
 alloc fail

On Fri, Dec 17, 2021 at 11:20:44PM +0800, Jiasheng Jiang wrote:
> The return value of devm_clk_get() needs to be checked.
> To avoid use of error pointer in case of the failure of alloc.

Please don't ignore review comments, people are generally making them
for a reason and are likely to have the same concerns if issues remain
unaddressed.  Having to repeat the same comments can get repetitive and
make people question the value of time spent reviewing.  If you disagree
with the review comments that's fine but you need to reply and discuss
your concerns so that the reviewer can understand your decisions.

I'm getting really annoyed with this...

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)