linux-kernel - Re: [PATCH v3 2/2] iio: accel: add ADXL367 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Dec 2021 00:29:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Cosmin Tanislav <demonsingur@...il.com>
Cc:     kbuild-all@...ts.01.org, cosmin.tanislav@...log.com,
        demonsingur@...il.com, Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Rob Herring <robh+dt@...nel.org>, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] iio: accel: add ADXL367 driver

Hi Cosmin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on robh/for-next linus/master v5.16-rc5 next-20211217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Cosmin-Tanislav/Add-ADXL367-driver/20211217-194722
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20211218/202112180019.g2mLoEZq-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c227f49f87d7be7884f44bfdd422713610cdd29c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Cosmin-Tanislav/Add-ADXL367-driver/20211217-194722
        git checkout c227f49f87d7be7884f44bfdd422713610cdd29c
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/iio/accel/ net/netfilter/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/iio/accel/adxl367.c:990:5: warning: no previous prototype for 'adxl367_write_raw_get_fmt' [-Wmissing-prototypes]
     990 | int adxl367_write_raw_get_fmt(struct iio_dev *indio_dev,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/iio/accel/adxl367.c:212:18: warning: 'adxl367_time_scale_tbl' defined but not used [-Wunused-const-variable=]
     212 | static const int adxl367_time_scale_tbl[] = {
         |                  ^~~~~~~~~~~~~~~~~~~~~~


vim +/adxl367_write_raw_get_fmt +990 drivers/iio/accel/adxl367.c

   989	
 > 990	int adxl367_write_raw_get_fmt(struct iio_dev *indio_dev,
   991				      struct iio_chan_spec const *chan,
   992				      long info)
   993	{
   994		switch (info) {
   995		case IIO_CHAN_INFO_SCALE:
   996			if (chan->type != IIO_ACCEL)
   997				return -EINVAL;
   998	
   999			return IIO_VAL_INT_PLUS_NANO;
  1000		default:
  1001			return IIO_VAL_INT_PLUS_MICRO;
  1002		}
  1003	}
  1004	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org