linux-kernel - Re: [PATCH] hwmon : (mr75203) fix macro typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yby+pwwCg4gagNEf@smile.fi.intel.com>
Date:   Fri, 17 Dec 2021 18:45:27 +0200
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Arseny Demidov <arsdemal@...il.com>, rahul.tanwar@...ux.intel.com,
        Arseny Demidov <a.demidov@...ro.com>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon : (mr75203) fix macro typo

On Fri, Dec 17, 2021 at 08:05:17AM -0800, Guenter Roeck wrote:
> On 12/16/21 6:19 AM, Andy Shevchenko wrote:
> > On Thu, Dec 16, 2021 at 11:33:02AM +0300, Arseny Demidov wrote:

...

> > > -#define POWER_DELAY_CYCLE_256	0x80
> > > +#define POWER_DELAY_CYCLE_256	0x100
> > >   #define POWER_DELAY_CYCLE_64	0x40
> > 
> > I;m wondering why they are in hex? Perhaps the decimal is better for both.
> > 
> Maybe, but that is POV, and I tend to leave it up to driver authors to decide.
> It is definitely not something we would want to change as part of a bug fix.

Agreed on both points.

-- 
With Best Regards,
Andy Shevchenko