[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YbzCKoKGpGgAtvdq@sirena.org.uk>
Date: Fri, 17 Dec 2021 17:00:26 +0000
From: Mark Brown <broonie@...nel.org>
To: Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc: matthias.bgg@...il.com, lgirdwood@...il.com,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] isoc: mediatek: Fix dereference of null pointer while
alloc fail
On Sat, Dec 18, 2021 at 12:52:20AM +0800, Jiasheng Jiang wrote:
> clk[i] = devm_clk_get(&pdev->dev, clk_names[i]);
> + if (IS_ERR(clk[i]))
> + return -ENOMEM;
As I and IIRC someone else pointed out there is an error code encoded in
the pointer if IS_ERR() is true, we should use that error code.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists