lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 18 Dec 2021 12:54:50 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     davidcomponentone@...il.com
Cc:     zbr@...emap.net, gregkh@...uxfoundation.org,
        yangyingliang@...wei.com, unixbhaskar@...il.com,
        ivan.zaentsev@...enboard.ru, yang.guang5@....com.cn,
        linux-kernel@...r.kernel.org, Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] w1: w1_therm: use swap() to make code cleaner

On Sat, Dec 18, 2021 at 09:58:44AM +0800, davidcomponentone@...il.com wrote:
> @@ -1837,7 +1837,7 @@ static ssize_t alarms_store(struct device *device,
>  
>  	/* Reorder if required th and tl */
>  	if (tl > th) {
> -		tt = tl; tl = th; th = tt;
> +		swap(tl, th);
>  	}

Delete the curly {} braces as well since they are no longer required.

regards,
dan carpenter

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ