linux-kernel - Re: [PATCH] 9p: fix unused-variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2222224.1639835496@warthog.procyon.org.uk>
Date:   Sat, 18 Dec 2021 13:51:36 +0000
From:   David Howells <dhowells@...hat.com>
To:     Dominique Martinet <asmadeus@...ewreck.org>
Cc:     dhowells@...hat.com, Arnd Bergmann <arnd@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Eric Van Hensbergen <ericvh@...il.com>,
        Latchesar Ionkov <lucho@...kov.net>,
        Jeff Layton <jlayton@...nel.org>,
        v9fs-developer@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 9p: fix unused-variable warning

Dominique Martinet <asmadeus@...ewreck.org> wrote:

> David since then fixed the warning differently in v2 of the patch (he
> moved the fscache_note_page_release() out of the ifdef), so I won't do
> anything with this even if in principle I tend to agree that
> if(IS_ENABLED()) lead to better compiler coverage

Yeah, fscache_note_page_release() compiles out in such a case because
v9fs_inode_cookie() becomes unconditionally NULL if it's disabled.

If you want me to do something different, can you give me an incremental patch
to merge into mine?

David