linux-kernel - Re: [PATCH v7 07/14] clk: en7523: Add clock driver for Airoha EN7523 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 19 Dec 2021 07:12:10 +0800
From:   kernel test robot <lkp@...el.com>
To:     Felix Fietkau <nbd@....name>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>
Cc:     kbuild-all@...ts.01.org, john@...ozen.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org
Subject: Re: [PATCH v7 07/14] clk: en7523: Add clock driver for Airoha EN7523
 SoC

Hi Felix,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on clk/clk-next v5.16-rc5 next-20211217]
[cannot apply to linusw-gpio/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Felix-Fietkau/dt-bindings-Add-vendor-prefix-for-Airoha/20211217-202345
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: sparc-randconfig-s031-20211218 (https://download.01.org/0day-ci/archive/20211219/202112190745.VhE9iVPk-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/64b3a07b51d637d0df89f00d061662f8228c0b13
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Felix-Fietkau/dt-bindings-Add-vendor-prefix-for-Airoha/20211217-202345
        git checkout 64b3a07b51d637d0df89f00d061662f8228c0b13
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=sparc SHELL=/bin/bash drivers/clk/ drivers/clocksource/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/clk/clk-en7523.c:240:27: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected void *np_base @@     got void [noderef] __iomem *base @@
   drivers/clk/clk-en7523.c:240:27: sparse:     expected void *np_base
   drivers/clk/clk-en7523.c:240:27: sparse:     got void [noderef] __iomem *base
>> drivers/clk/clk-en7523.c:243:29: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const volatile [noderef] __iomem *addr @@     got void * @@
   drivers/clk/clk-en7523.c:243:29: sparse:     expected void const volatile [noderef] __iomem *addr
   drivers/clk/clk-en7523.c:243:29: sparse:     got void *
>> drivers/clk/clk-en7523.c:245:29: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void volatile [noderef] __iomem *addr @@     got void * @@
   drivers/clk/clk-en7523.c:245:29: sparse:     expected void volatile [noderef] __iomem *addr
   drivers/clk/clk-en7523.c:245:29: sparse:     got void *

vim +240 drivers/clk/clk-en7523.c

   236	
   237	static void en7523_pci_disable(struct clk_hw *hw)
   238	{
   239		struct en_clk_gate *cg = container_of(hw, struct en_clk_gate, hw);
 > 240		void *np_base = cg->base;
   241		u32 val;
   242	
 > 243		val = readl(np_base + REG_PCI_CONTROL);
   244		val &= ~REG_PCI_CONTROL_REFCLK_EN1;
 > 245		writel(val, np_base + REG_PCI_CONTROL);
   246	}
   247	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org