linux-kernel - drivers/crypto/sa2ul.c:432:1: warning: the frame size of 1088 bytes is larger than 1024 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 19 Dec 2021 07:52:53 +0800
From:   kernel test robot <lkp@...el.com>
To:     Keerthy <j-keerthy@...com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Tero Kristo <t-kristo@...com>
Subject: drivers/crypto/sa2ul.c:432:1: warning: the frame size of 1088 bytes
 is larger than 1024 bytes

Hi Keerthy,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   9eaa88c7036eda3f6c215f87ca693594cf90559b
commit: d2c8ac187fc922e73930a1b2f6a211e27f595d01 crypto: sa2ul - Add AEAD algorithm support
date:   1 year, 5 months ago
config: mips-randconfig-p002-20211218 (https://download.01.org/0day-ci/archive/20211219/202112190729.P81P29Nc-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d2c8ac187fc922e73930a1b2f6a211e27f595d01
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout d2c8ac187fc922e73930a1b2f6a211e27f595d01
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash drivers/crypto/ drivers/opp/ drivers/pinctrl/ drivers/usb/chipidea/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/linux/dmaengine.h:8,
                    from drivers/crypto/sa2ul.c:12:
   drivers/crypto/sa2ul.c: In function 'sa_sha_init':
   drivers/crypto/sa2ul.c:1486:47: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    1486 |                 crypto_ahash_digestsize(tfm), (u64)rctx);
         |                                               ^
   include/linux/dev_printk.h:123:61: note: in definition of macro 'dev_dbg'
     123 |                 dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
         |                                                             ^~~~~~~~~~~
   drivers/crypto/sa2ul.c: In function 'sa_prepare_iopads':
>> drivers/crypto/sa2ul.c:432:1: warning: the frame size of 1088 bytes is larger than 1024 bytes [-Wframe-larger-than=]
     432 | }
         | ^


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> drivers/usb/chipidea/core.c:596:15: warning: Local variable ci_role shadows outer function [shadowFunction]
    enum ci_role ci_role = usb_role_to_ci_role(role);
                 ^
   drivers/usb/chipidea/ci.h:262:38: note: Shadowed declaration
   static inline struct ci_role_driver *ci_role(struct ci_hdrc *ci)
                                        ^
   drivers/usb/chipidea/core.c:596:15: note: Shadow variable
    enum ci_role ci_role = usb_role_to_ci_role(role);
                 ^
>> drivers/opp/core.c:1395:4: warning: Address of local auto-variable assigned to a function parameter. [autoVariables]
      *head = &opp->node;
      ^

vim +432 drivers/crypto/sa2ul.c

   407	
   408	static void sa_prepare_iopads(struct algo_data *data, const u8 *key,
   409				      u16 key_sz, __be32 *ipad, __be32 *opad)
   410	{
   411		SHASH_DESC_ON_STACK(shash, data->ctx->shash);
   412		int block_size = crypto_shash_blocksize(data->ctx->shash);
   413		int digest_size = crypto_shash_digestsize(data->ctx->shash);
   414		u8 k_ipad[SHA1_BLOCK_SIZE];
   415		u8 k_opad[SHA1_BLOCK_SIZE];
   416	
   417		shash->tfm = data->ctx->shash;
   418	
   419		prepare_kiopad(k_ipad, k_opad, key, key_sz);
   420	
   421		memzero_explicit(ipad, block_size);
   422		memzero_explicit(opad, block_size);
   423	
   424		crypto_shash_init(shash);
   425		crypto_shash_update(shash, k_ipad, block_size);
   426		sa_export_shash(shash, block_size, digest_size, ipad);
   427	
   428		crypto_shash_init(shash);
   429		crypto_shash_update(shash, k_opad, block_size);
   430	
   431		sa_export_shash(shash, block_size, digest_size, opad);
 > 432	}
   433	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org