[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5471232.RFuYXYORHR@diego>
Date: Sun, 19 Dec 2021 22:56:57 +0100
From: Heiko Stübner <heiko@...ech.de>
To: plr.vincent@...il.com, linux-riscv@...ts.infradead.org
Cc: robh+dt@...nel.org, Paul Walmsley <paul.walmsley@...ive.com>,
aou@...s.berkeley.edu, krzysztof.kozlowski@...onical.com,
qiuwenbo@...inos.com.cn, devicetree@...r.kernel.org,
linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
david.abdurachmanov@...ive.com, Palmer Dabbelt <palmer@...belt.com>
Subject: Re: [PATCH v3 4/6] riscv: dts: sifive unmatched: Expose the FU740 core supply regulator
Am Freitag, 17. Dezember 2021, 06:35:00 CET schrieb Palmer Dabbelt:
> On Fri, 19 Nov 2021 14:55:40 PST (-0800), plr.vincent@...il.com wrote:
> > Provides monitoring of core voltage and current:
> > tps544b20-i2c-0-1e
> > Adapter: i2c-ocores
> > vout1: 906.00 mV
> > temp1: -40.0°C (high = +125.0°C, crit = +150.0°C)
> > iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A)
> >
> > Signed-off-by: Vincent Pelletier <plr.vincent@...il.com>
> >
> > ---
> > Note: checkpatch.pl complains about undocumented devicetree binding,
> > which is fixed by:
> > https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u
> >
> > Changes since v2:
> > - Fix end-of-commit-message separator so change lists do not end up in them.
> > Changes since v1:
> > - Added missing "ti," prefix in compatible string.
> > - Remove trailing "." on subject line.
> > - Rename tree node.
>
> I see this in Rob's for-next as 761de79adc2c ("dt-bindings: hwmon: add
> TI DC-DC converters"), so I'm going to hold off on this one until the
> bindings land.
Can't this patch then simply go into your for-next branch then?
The split is most times binding goes through the driver-tree
(or Rob's dt tree) and the dts patch through an arch or soc tree.
But in general once a maintainer accepts the binding it is ok
to also apply the dts patch for the same cycle (aka merge window)
the binding will be in.
Heiko
>
> I've put the others on fixes.
>
> Thanks!
>
> > ---
> > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > index 270360b258b7..6e7775fdae32 100644
> > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > @@ -51,6 +51,11 @@ &uart1 {
> > &i2c0 {
> > status = "okay";
> >
> > + regulator@1e {
> > + compatible = "ti,tps544b20";
> > + reg = <0x1e>;
> > + };
> > +
> > temperature-sensor@4c {
> > compatible = "ti,tmp451";
> > reg = <0x4c>;
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
>
Powered by blists - more mailing lists