linux-kernel - Re: [GIT PULL 1/2] arm64: TI K3 SoC configs changes for v5.17

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2VSBvOn1o+q1PYZaQ6LS9U4cz+DZGuDbisHkwNs2dAAw@mail.gmail.com>
Date:   Mon, 20 Dec 2021 16:27:37 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Vignesh Raghavendra <vigneshr@...com>
Cc:     Nishanth Menon <nm@...com>, Arnd Bergmann <arnd@...db.de>,
        Olof Johansson <olof@...om.net>, SoC <soc@...nel.org>,
        arm-soc <arm@...nel.org>, Tero Kristo <kristo@...nel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL 1/2] arm64: TI K3 SoC configs changes for v5.17

On Fri, Dec 17, 2021 at 6:28 PM Vignesh Raghavendra <vigneshr@...com> wrote:
>
> The following changes since commit fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf:
>
>   Linux 5.16-rc1 (2021-11-14 13:56:52 -0800)
>
> are available in the Git repository at:
>
>   https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git tags/ti-k3-config-for-v5.17
>
> for you to fetch changes up to 8d73aedca28cbed8030067b0d9423a0694139b9c:
>
>   arm64: defconfig: Enable USB, PCIe and SERDES drivers for TI K3 SoC (2021-12-14 16:22:25 +0530)
>
> ----------------------------------------------------------------
> ARM64 defconfig changes for TI K3 platforms for v5.17 merge window:
>
> - Increase No. of 8250 UARTs supported in System to 16 for J721s2

This looks a little excessive, I'm holding off on this pull request
for now, as I'm
not sure exactly what the downsides are.

I see that your dtsi file has

+       aliases {
+               serial0 = &wkup_uart0;
+               serial1 = &mcu_uart0;
+               serial2 = &main_uart0;
+               serial3 = &main_uart1;
+               serial4 = &main_uart2;
+               serial5 = &main_uart3;
+               serial6 = &main_uart4;
+               serial7 = &main_uart5;
+               serial8 = &main_uart6;
+               serial9 = &main_uart7;
+               serial10 = &main_uart8;
+               serial11 = &main_uart9;
+               mmc0 = &main_sdhci0;
+               mmc1 = &main_sdhci1;
+               can0 = &main_mcan16;
+               can1 = &mcu_mcan0;
+               can2 = &mcu_mcan1;
+               can3 = &main_mcan3;
+               can4 = &main_mcan5;
+       };

which I think is the underlying problem here. The aliases are really meant to
be board specific, and I would assume that none of the boards actually
uses all the
uart and can bus devices, usually this isn't even possible due to pinctrl
constraints, so please follow up by moving these to the .dts files listing only
the actually used devices instead of working around it in the defconfig.

> - Enable USB, PCIe and SERDES drivers on TI K3 SoC

I see the PCIe driver is built-in here. Is that necessary for booting?
If not, please
make it a loadable module.

       Arnd