linux-kernel - Re: [PATCH v1] memory: tegra30-emc: Print additional memory info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af428524-c630-64b9-5d67-22714ebe8d15@gmail.com>
Date:   Mon, 20 Dec 2021 18:27:20 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Svyatoslav Ryhel <clamor95@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH v1] memory: tegra30-emc: Print additional memory info

18.12.2021 02:47, Dmitry Osipenko пишет:
> +static int emc_read_lpddr_mode_register(struct tegra_emc *emc,
> +					unsigned int emem_dev,
> +					unsigned int register_addr,
> +					unsigned int *register_data)
> +{
> +	u32 memory_dev = emem_dev + 1;

I just noticed in the datasheet that memory_dev needs to be inverted,
otherwise we read dev0 instead of dev1 and vice versa. This also needs
to be corrected in the T20 EMC driver. It's not really a problem since
both memory chips usually are equal, nevertheless I'll fix it in v2
after we will decide on whether this code needs to be shared or not.