| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1640022750-16263-1-git-send-email-sean.wang@mediatek.com>
Date: Tue, 21 Dec 2021 01:52:30 +0800
From: <sean.wang@...iatek.com>
To: <pmenzel@...gen.mpg.de>
CC: <marcel@...tmann.org>, <johan.hedberg@...il.com>,
<Mark-YW.Chen@...iatek.com>, <sean.wang@...iatek.com>,
<Soul.Huang@...iatek.com>, <YN.Chen@...iatek.com>,
<Leon.Yen@...iatek.com>, <Eric-SY.Chang@...iatek.com>,
<Deren.Wu@...iatek.com>, <km.lin@...iatek.com>,
<robin.chiu@...iatek.com>, <Eddie.Chen@...iatek.com>,
<ch.yeh@...iatek.com>, <posh.sun@...iatek.com>,
<ted.huang@...iatek.com>, <Eric.Liang@...iatek.com>,
<Stella.Chang@...iatek.com>, <Tom.Chou@...iatek.com>,
<steve.lee@...iatek.com>, <jsiuda@...gle.com>,
<frankgor@...gle.com>, <jemele@...gle.com>,
<abhishekpandit@...gle.com>, <michaelfsun@...gle.com>,
<mcchou@...omium.org>, <shawnku@...gle.com>,
<linux-bluetooth@...r.kernel.org>,
<linux-mediatek@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] Bluetooth: btmtksdio: Enable SCO over I2S function
From: Sean Wang <sean.wang@...iatek.com>
>Dear Sean, dear Mark,
>
>
>Am 18.12.21 um 02:08 schrieb sean.wang@...iatek.com:
>> From: Mark Chen <mark-yw.chen@...iatek.com>
>>
>> For MediaTek chipset, the driver has to issue the specific command to
>> enable Bluetooth SCO support over the I2S/PCM interface.
>
>Please document the datasheet name, revision and section, where this is described.
the datasheet is not released in public so Mark and I cannot provide the detail here, but we will make the patch easy to review and understand.
>
>Please add how SCO support can be tested. Are all Mediatek chipsets supported?
the SCO profile was tested by setting up a VOIP application, connected to HFP device, checked telephony function can work normally.
currently, SCO is only supported by mt7921, we will change the subject to "Bluetooth: mt7921s: Enable SCO over I2S function" to avoid any misunderstanding.
>
>> Co-developed-by: Sean Wang <sean.wang@...iatek.com>
>> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
>> Signed-off-by: Mark Chen <mark-yw.chen@...iatek.com>
>> ---
>> drivers/bluetooth/btmtk.h | 20 +++++++++
>> drivers/bluetooth/btmtksdio.c | 76 +++++++++++++++++++++++++++++++++++
>> 2 files changed, 96 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btmtk.h b/drivers/bluetooth/btmtk.h
>> index 2be1d2680ad8..fc57ef09d132 100644
>> --- a/drivers/bluetooth/btmtk.h
>> +++ b/drivers/bluetooth/btmtk.h
>> @@ -7,8 +7,12 @@
>>
>> #define HCI_WMT_MAX_EVENT_SIZE 64
>>
>> +#define BTMTK_WMT_REG_WRITE 0x1
>> #define BTMTK_WMT_REG_READ 0x2
>>
>> +#define MT7921_PINMUX_0 0x70005050
>> +#define MT7921_PINMUX_1 0x70005054
>> +
>> enum {
>> BTMTK_WMT_PATCH_DWNLD = 0x1,
>> BTMTK_WMT_TEST = 0x2,
>> @@ -76,6 +80,22 @@ struct btmtk_wakeon {
>> __le16 wakeup_delay;
>> } __packed;
>>
>> +struct btmtk_sco {
>> + u8 clock_config;
>> + u8 transmit_format_config;
>> + u8 channel_format_config;
>> + u8 channel_select_config;
>> +} __packed;
>> +
>> +struct reg_write_cmd {
>> + u8 type;
>> + u8 rsv;
>> + u8 num;
>> + __le32 addr;
>> + __le32 data;
>> + __le32 mask;
>> +} __packed;
>> +
>> struct btmtk_hci_wmt_params {
>> u8 op;
>> u8 flag;
>> diff --git a/drivers/bluetooth/btmtksdio.c
>> b/drivers/bluetooth/btmtksdio.c index 771733ce362b..8e4d8c2da824
>> 100644
>> --- a/drivers/bluetooth/btmtksdio.c
>> +++ b/drivers/bluetooth/btmtksdio.c
>> @@ -830,6 +830,74 @@ static int btsdio_mtk_reg_read(struct hci_dev *hdev, u32 reg, u32 *val)
>> return err;
>> }
>>
>> +static int btsdio_mtk_reg_write(struct hci_dev *hdev, u32 reg, u32
>> +val, u32 mask) {
>> + struct btmtk_hci_wmt_params wmt_params;
>> + struct reg_write_cmd reg_write = {
>> + .type = 1,
>> + .num = 1,
>> + .addr = cpu_to_le32(reg),
>> + .data = cpu_to_le32(val),
>> + .mask = cpu_to_le32(mask),
>> + };
>> + int err, status;
>> +
>> + wmt_params.op = BTMTK_WMT_REGISTER;
>> + wmt_params.flag = BTMTK_WMT_REG_WRITE;
>> + wmt_params.dlen = sizeof(reg_write);
>> + wmt_params.data = ®_write;
>> + wmt_params.status = &status;
>> +
>> + err = mtk_hci_wmt_sync(hdev, &wmt_params);
>> + if (err < 0)
>> + bt_dev_err(hdev, "Failed to write reg(%d)", err);
>> +
>> + return err;
>> +}
>> +
>> +static int btsdio_mtk_sco_setting(struct hci_dev *hdev) {
>> + struct btmtk_sco sco_setting = {
>> + .clock_config = 0x49,
>> + .channel_format_config = 0x80,
>> + };
>> + struct sk_buff *skb;
>> + u32 val;
>> + int err;
>> +
>> + /* Enable SCO over i2s/pcm for Mediatek Chipset */
>
>s/Chipset/chipset/
will do in the next version
>
>> + skb = __hci_cmd_sync(hdev, 0xfc72, sizeof(sco_setting),
>> + &sco_setting, HCI_CMD_TIMEOUT);
>> + if (IS_ERR(skb))
>> + return PTR_ERR(skb);
>> +
>> + err = btsdio_mtk_reg_read(hdev, MT7921_PINMUX_0, &val);
>> + if (err < 0) {
>> + bt_dev_err(hdev, "Failed to read register (%d)", err);
>> + return err;
>> + }
>> +
>> + val |= 0x11000000;
>> + err = btsdio_mtk_reg_write(hdev, MT7921_PINMUX_0, val, ~0);
>> + if (err < 0) {
>> + bt_dev_err(hdev, "Failed to write register (%d)", err);
>> + return err;
>> + }
>> +
>> + err = btsdio_mtk_reg_read(hdev, MT7921_PINMUX_1, &val);
>> + if (err < 0) {
>> + bt_dev_err(hdev, "Failed to read register (%d)", err);
>> + return err;
>> + }
>> +
>> + val |= 0x00000101;
>> + err = btsdio_mtk_reg_write(hdev, MT7921_PINMUX_1, val, ~0);
>> + if (err < 0)
>> + bt_dev_err(hdev, "Failed to write register (%d)", err);
>> +
>> + return err;
>> +}
>> +
>> static int btmtksdio_setup(struct hci_dev *hdev)
>> {
>> struct btmtksdio_dev *bdev = hci_get_drvdata(hdev); @@ -862,6
>> +930,14 @@ static int btmtksdio_setup(struct hci_dev *hdev)
>> err = mt79xx_setup(hdev, fwname);
>> if (err < 0)
>> return err;
>> +
>> + /* Enable sco over i2s/pcm */
>
>s/sco/SCO/
ditto
>
>> + err = btsdio_mtk_sco_setting(hdev);
>> + if (err < 0) {
>> + bt_dev_err(hdev, "Failed to enable sco setting (%d)", err);
>
>s/sco/SCO/
ditto
>
>> + return err;
>> + }
>> +
>> break;
>> case 0x7663:
>> case 0x7668:
>
>
>Kind regards,
>
>Paul
>
Powered by blists - more mailing lists