linux-kernel - Re: [PATCH v4] rtw88: Disable PCIe ASPM while doing NAPI poll on 8821CE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <164002609722.16553.11425068672466234976.kvalo@kernel.org>
Date:   Mon, 20 Dec 2021 18:48:20 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     tony0620emma@...il.com, pkshih@...ltek.com, jian-hong@...lessm.com,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Po-Hao Huang <phhuang@...ltek.com>,
        Brian Norris <briannorris@...omium.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] rtw88: Disable PCIe ASPM while doing NAPI poll on
 8821CE

Kai-Heng Feng <kai.heng.feng@...onical.com> wrote:

> Many Intel based platforms face system random freeze after commit
> 9e2fd29864c5 ("rtw88: add napi support").
> 
> The commit itself shouldn't be the culprit. My guess is that the 8821CE
> only leaves ASPM L1 for a short period when IRQ is raised. Since IRQ is
> masked during NAPI polling, the PCIe link stays at L1 and makes RX DMA
> extremely slow. Eventually the RX ring becomes messed up:
> [ 1133.194697] rtw_8821ce 0000:02:00.0: pci bus timeout, check dma status
> 
> Since the 8821CE hardware may fail to leave ASPM L1, manually do it in
> the driver to resolve the issue.
> 
> Fixes: 9e2fd29864c5 ("rtw88: add napi support")
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215131
> BugLink: https://bugs.launchpad.net/bugs/1927808
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> Acked-by: Jian-Hong Pan <jhp@...lessos.org>

Patch applied to wireless-drivers-next.git, thanks.

24f5e38a13b5 rtw88: Disable PCIe ASPM while doing NAPI poll on 8821CE

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211215114635.333767-1-kai.heng.feng@canonical.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches