linux-kernel - Re: [PATCH] staging: vt6655: drop off byRxMode var in device.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Dec 2021 20:31:57 +0100
From:   Tommaso Merciai <tomm.merciai@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linuxfancy@...glegroups.com,
        Forest Bond <forest@...ttletooquiet.net>,
        Alberto Merciai <alb3rt0.m3rciai@...il.com>,
        Karolina Drobnik <karolinadrobnik@...il.com>,
        Aldas Taraškevičius <aldas60@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6655: drop off byRxMode var in device.h

On Mon, Dec 20, 2021 at 05:39:18PM +0100, Greg Kroah-Hartman wrote:
> On Sun, Dec 19, 2021 at 07:20:03PM +0100, Tommaso Merciai wrote:
> > Drop off unused variable byRxMode in device.h, this fix following 
> > checkpatch.pl check:
> > 
> > CHECK: Avoid CamelCase: <byRxMode>
> > 131: FILE: drivers/staging/vt6655/device.h:131:
> > 	unsigned char byRxMode
> > 
> > Signed-off-by: Tommaso Merciai <tomm.merciai@...il.com>
> > ---
> >  drivers/staging/vt6655/device.h | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> > index 4706bde1ec1d..84b1dcf80e47 100644
> > --- a/drivers/staging/vt6655/device.h
> > +++ b/drivers/staging/vt6655/device.h
> > @@ -128,8 +128,6 @@ struct vnt_private {
> >  	u32                         memaddr;
> >  	u32                         ioaddr;
> >  
> > -	unsigned char byRxMode;
> > -
> >  	spinlock_t                  lock;
> >  
> >  	volatile int                iTDUsed[TYPE_MAXTD];
> > -- 
> > 2.25.1
> > 
> > 
> 
> Did you send this twice?  What is the difference between the two
> versions?

Hi Gregh,
I send twice for error, sorry.
> 
> And you have trailing whitespace in the changelog for this message,
> please fix.
I'll fix and send v2.

> 
> thanks,
> 
> greg k-h

thanks,
tommaso