linux-kernel - Re: [PATCH v1 1/1] hwmon : (mr75203) fix wrong power-up delay value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211220210311.GA194769@roeck-us.net>
Date:   Mon, 20 Dec 2021 13:03:11 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Arseny Demidov <arsdemal@...il.com>
Cc:     linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jean Delvare <jdelvare@...e.com>, rahul.tanwar@...ux.intel.com,
        andriy.shevchenko@...el.com, Arseny Demidov <a.demidov@...ro.com>
Subject: Re: [PATCH v1 1/1] hwmon : (mr75203) fix wrong power-up delay value

On Sun, Dec 19, 2021 at 01:22:39PM +0300, Arseny Demidov wrote:
> In the file mr75203.c we have a macro named POWER_DELAY_CYCLE_256,
> the correct value should be 0x100. The register ip_tmr is expressed
> in units of IP clk cycles, in accordance with the datasheet.
> Typical power-up delays for Temperature Sensor are 256 cycles i.e. 0x100.
> 
> Fixes: 9d823351a337 ("hwmon: Add hardware monitoring driver for Moortec MR75203 PVT controller")
> Signed-off-by: Arseny Demidov <a.demidov@...ro.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/mr75203.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon/mr75203.c
> index 868243dba1ee..1ba1e3145969 100644
> --- a/drivers/hwmon/mr75203.c
> +++ b/drivers/hwmon/mr75203.c
> @@ -93,7 +93,7 @@
>  #define VM_CH_REQ	BIT(21)
>  
>  #define IP_TMR			0x05
> -#define POWER_DELAY_CYCLE_256	0x80
> +#define POWER_DELAY_CYCLE_256	0x100
>  #define POWER_DELAY_CYCLE_64	0x40
>  
>  #define PVT_POLL_DELAY_US	20