linux-kernel - Re: [PATCH] watchdog: s3c2410: Fix getting the optional clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ad8719c-1476-3226-e426-a171b46ca568@roeck-us.net>
Date:   Mon, 20 Dec 2021 13:08:11 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Sam Protsenko <semen.protsenko@...aro.org>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: s3c2410: Fix getting the optional clock

On 12/20/21 7:15 AM, Sam Protsenko wrote:
> On Sun, 12 Dec 2021 at 19:50, Krzysztof Kozlowski
> <krzysztof.kozlowski@...onical.com> wrote:
>>
>> On 12/12/2021 18:02, Sam Protsenko wrote:
>>> "watchdog_src" clock is optional and may not be present for some SoCs
>>> supported by this driver. Nevertheless, in case the clock is provided
>>> but some error happens during its getting, that error should be handled
>>> properly. Use devm_clk_get_optional() API for that. Also report possible
>>> errors using dev_err_probe() to handle properly -EPROBE_DEFER error (if
>>> clock provider is not ready by the time WDT probe function is executed).
>>>
>>> Fixes: a4f3dc8d5fbc ("watchdog: s3c2410: Support separate source clock")
>>> Reported-by: kernel test robot <lkp@...el.com>
>>> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
>>> Suggested-by: Guenter Roeck <linux@...ck-us.net>
>>> Signed-off-by: Sam Protsenko <semen.protsenko@...aro.org>
>>> ---
>>>   drivers/watchdog/s3c2410_wdt.c | 22 ++++++++++++----------
>>>   1 file changed, 12 insertions(+), 10 deletions(-)
>>>
>>
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
>>
> 
> Hi Guenter,
> 
> If there are no outstanding concerns, can you please apply this one?
> Would be nice to see it in v5.17 if that's possible.
> 

I added the patch to my watchdog-next tree, but Wim handles all pull
requests.

Thanks,
Guenter