linux-kernel - Re: [PATCH for-stable] KVM: VMX: clear vmx_x86_ops.sync_pir_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YcBTKJ08/7tjOBAu@kroah.com>
Date:   Mon, 20 Dec 2021 10:55:52 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH for-stable] KVM: VMX: clear vmx_x86_ops.sync_pir_to_irr
 if APICv is disabled

On Mon, Dec 20, 2021 at 10:49:50AM +0100, Paolo Bonzini wrote:
> commit e90e51d5f01d2baae5dcce280866bbb96816e978 upstream.
> 
> There is nothing to synchronize if APICv is disabled, since neither
> other vCPUs nor assigned devices can set PIR.ON.
> 
> After the patch was committed to Linus's tree, it was observed that
> this fixes an issue with commit 7e1901f6c86c ("KVM: VMX: prepare
> sync_pir_to_irr for running with APICv disabled", backported to stable
> as e.g. commit 70a37e04c08a for the 5.15 tree).  Without this patch,
> vmx_sync_pir_to_irr can be reached with enable_apicv == false, triggering
> 
>  	if (KVM_BUG_ON(!enable_apicv, vcpu->kvm))
> 
> Fixes: 7e1901f6c86c ("KVM: VMX: prepare sync_pir_to_irr for running with APICv disabled")
> Cc: stable@...r.kernel.org
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> ---
>  arch/x86/kvm/vmx/vmx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Looks like it is already queued up, thanks.

greg k-h