linux-kernel - Re: [PATCH 5/6] usb: cdns3: Use platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95e016e9-4259-c1d6-f73c-ad79b7cef413@kernel.org>
Date:   Mon, 20 Dec 2021 12:48:26 +0200
From:   Roger Quadros <rogerq@...nel.org>
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Rob Herring <robh+dt@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, Peter Chen <peter.chen@...nel.org>,
        Pawel Laszczak <pawell@...ence.com>,
        Aswath Govindraju <a-govindraju@...com>,
        Felipe Balbi <balbi@...nel.org>,
        Rui Miguel Silva <rui.silva@...aro.org>,
        Bin Liu <b-liu@...com>
Cc:     linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Prabhakar <prabhakar.csengg@...il.com>
Subject: Re: [PATCH 5/6] usb: cdns3: Use platform_get_irq_byname() to get the
 interrupt



On 20/12/2021 03:04, Lad Prabhakar wrote:
> platform_get_resource_byname(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
> 
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq_byname().
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> ---
>  drivers/usb/cdns3/cdns3-plat.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat.c
> index 4d0f027e5bd3..dc068e940ed5 100644
> --- a/drivers/usb/cdns3/cdns3-plat.c
> +++ b/drivers/usb/cdns3/cdns3-plat.c
> @@ -13,6 +13,7 @@
>   */
>  
>  #include <linux/module.h>
> +#include <linux/irq.h>
>  #include <linux/kernel.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
> @@ -65,13 +66,14 @@ static int cdns3_plat_probe(struct platform_device *pdev)
>  
>  	platform_set_drvdata(pdev, cdns);
>  
> -	res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "host");
> -	if (!res) {
> -		dev_err(dev, "missing host IRQ\n");
> -		return -ENODEV;
> -	}
> +	ret = platform_get_irq_byname(pdev, "host");
> +	if (ret < 0)
> +		return ret;
>  
> -	cdns->xhci_res[0] = *res;
> +	cdns->xhci_res[0].start = ret;
> +	cdns->xhci_res[0].end = ret;
> +	cdns->xhci_res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(ret);
> +	cdns->xhci_res[0].name = "host";
>  
>  	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "xhci");
>  	if (!res) {
> 

Reviewed-by: Roger Quadros <rogerq@...nel.org>

--
cheers,
-roger