linux-kernel - Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Dec 2021 17:53:23 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Peter Geis <pgwipeout@...il.com>, Lee Jones <lee.jones@...aro.org>
Cc:     Robin Murphy <robin.murphy@....com>,
        Heiko Stuebner <heiko@...ech.de>,
        linux-rockchip@...ts.infradead.org,
        Nicolas Frattaroli <frattaroli.nicolas@...il.com>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c

20.12.2021 17:46, Peter Geis пишет:
> +static int rk808_restart_notify(struct notifier_block *this, unsigned long mode, void *cmd)
> +{
> +	int ret;
> +	unsigned int reg, bit;
> +	struct rk808 *rk808 = i2c_get_clientdata(rk808_i2c_client);

Such code usually should be written in a form of reverse Xmas tree in
kernel, but no need to respin just because of it. The patch looks good
to me, thank you.

Reviewed-by: Dmitry Osipenko <digetx@...il.com>