linux-kernel - Re: [PATCH] dt-bindings: display: Add SPI peripheral schema to SPI based displays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Dec 2021 18:12:50 +0000
From:   Paul Cercueil <paul@...pouillou.net>
To:     Rob Herring <robh@...nel.org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Linus Walleij <linus.walleij@...aro.org>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Jonathan Bakker <xc-racer2@...e.ca>,
        Maxime Ripard <mripard@...nel.org>,
        Marek Belisko <marek@...delico.com>,
        "H. Nikolaus Schaller" <hns@...delico.com>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: display: Add SPI peripheral schema to SPI
 based displays

Hi Rob,

Le mar., déc. 21 2021 at 08:52:09 -0400, Rob Herring <robh@...nel.org> 
a écrit :
> With 'unevaluatedProperties' support enabled, several SPI based 
> display
> binding examples have warnings:
> 
> Documentation/devicetree/bindings/display/panel/samsung,ld9040.example.dt.yaml: 
> lcd@0: Unevaluated properties are not allowed ('#address-cells', 
> '#size-cells', 'spi-max-frequency', 'spi-cpol', 'spi-cpha' were 
> unexpected)
> Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.example.dt.yaml: 
> panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 
> 'spi-3wire' were unexpected)
> Documentation/devicetree/bindings/display/panel/ilitek,ili9322.example.dt.yaml: 
> display@0: Unevaluated properties are not allowed ('reg' was 
> unexpected)
> Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.example.dt.yaml: 
> display@0: Unevaluated properties are not allowed 
> ('spi-max-frequency' was unexpected)
> Documentation/devicetree/bindings/display/panel/abt,y030xx067a.example.dt.yaml: 
> panel@0: Unevaluated properties are not allowed ('spi-max-frequency' 
> was unexpected)
> Documentation/devicetree/bindings/display/panel/sony,acx565akm.example.dt.yaml: 
> panel@2: Unevaluated properties are not allowed ('spi-max-frequency', 
> 'reg' were unexpected)
> Documentation/devicetree/bindings/display/panel/tpo,td.example.dt.yaml: 
> panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 
> 'spi-cpol', 'spi-cpha' were unexpected)
> Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.example.dt.yaml: 
> panel@0: Unevaluated properties are not allowed ('reg', 
> 'spi-max-frequency', 'spi-cpol', 'spi-cpha' were unexpected)
> Documentation/devicetree/bindings/display/panel/innolux,ej030na.example.dt.yaml: 
> panel@0: Unevaluated properties are not allowed ('spi-max-frequency' 
> was unexpected)
> Documentation/devicetree/bindings/display/panel/sitronix,st7789v.example.dt.yaml: 
> panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 
> 'spi-cpol', 'spi-cpha' were unexpected)
> 
> Fix all of these by adding a reference to spi-peripheral-props.yaml.
> With this, the description that the binding must follow
> spi-controller.yaml is both a bit out of date and redundant, so remove
> it.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>

Acked-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul