[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c084037b-1f30-53be-bf6b-06e3401b20e8@csgroup.eu>
Date: Tue, 21 Dec 2021 18:43:11 +0000
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: "guoren@...nel.org" <guoren@...nel.org>,
"will@...nel.org" <will@...nel.org>,
"tglx@...utronix.de" <tglx@...utronix.de>,
"benh@...nel.crashing.org" <benh@...nel.crashing.org>,
"arnd@...db.de" <arnd@...db.de>,
"mingo@...hat.com" <mingo@...hat.com>,
"peterz@...radead.org" <peterz@...radead.org>,
"juri.lelli@...hat.com" <juri.lelli@...hat.com>
CC: "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
Guo Ren <guoren@...ux.alibaba.com>,
"x86@...nel.org" <x86@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"sparclinux@...r.kernel.or" <sparclinux@...r.kernel.or>,
"linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
"inux-parisc@...r.kernel.org" <inux-parisc@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 4/8] sched: powerpc: Remove unused TASK_SIZE_OF
Le 21/12/2021 à 18:00, guoren@...nel.org a écrit :
> From: Guo Ren <guoren@...ux.alibaba.com>
>
> This macro isn't used in Linux sched, now. Delete in
> include/linux/sched.h and arch's include/asm.
>
> Signed-off-by: Guo Ren <guoren@...ux.alibaba.com>
> ---
> arch/powerpc/include/asm/task_size_64.h | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/task_size_64.h b/arch/powerpc/include/asm/task_size_64.h
> index c993482237ed..7e2eca4fac4d 100644
> --- a/arch/powerpc/include/asm/task_size_64.h
> +++ b/arch/powerpc/include/asm/task_size_64.h
> @@ -44,12 +44,10 @@
> */
> #define TASK_SIZE_USER32 (0x0000000100000000UL - (1 * PAGE_SIZE))
>
> -#define TASK_SIZE_OF(tsk) \
> - (test_tsk_thread_flag(tsk, TIF_32BIT) ? TASK_SIZE_USER32 : \
> +#define TASK_SIZE \
> + (test_tsk_thread_flag(current, TIF_32BIT) ? TASK_SIZE_USER32 : \
> TASK_SIZE_USER64)
I think you should use test_thread_flag() instead.
Or even better: use is_32bit_task() and bring back this macro as a
single line, something like:
#define TASK_SIZE (is_32bit_task() ? TASK_SIZE_USER32 : TASK_SIZE_USER64)
>
> -#define TASK_SIZE TASK_SIZE_OF(current)
> -
> #define TASK_UNMAPPED_BASE_USER32 (PAGE_ALIGN(TASK_SIZE_USER32 / 4))
> #define TASK_UNMAPPED_BASE_USER64 (PAGE_ALIGN(DEFAULT_MAP_WINDOW_USER64 / 4))
>
>
Powered by blists - more mailing lists