linux-kernel - Re: [PATCH v1 1/3] platform/x86: asus-wmi: Join string literals back

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a81d0b0-2dd6-7245-3eef-9fbbf864cbb5@redhat.com>
Date:   Tue, 21 Dec 2021 19:53:46 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "Luke D. Jones" <luke@...nes.dev>,
        acpi4asus-user@...ts.sourceforge.net,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Corentin Chary <corentin.chary@...il.com>,
        Mark Gross <markgross@...nel.org>
Subject: Re: [PATCH v1 1/3] platform/x86: asus-wmi: Join string literals back

Hi,

On 12/10/21 17:30, Andy Shevchenko wrote:
> For easy grepping on debug purposes join string literals back in
> the messages.
> 
> No functional change.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
>  drivers/platform/x86/asus-wmi.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 6fa4b0be8e76..30e0de9e0d81 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -1154,12 +1154,10 @@ static void asus_rfkill_hotplug(struct asus_wmi *asus)
>  		absent = (l == 0xffffffff);
>  
>  		if (blocked != absent) {
> -			pr_warn("BIOS says wireless lan is %s, "
> -				"but the pci device is %s\n",
> +			pr_warn("BIOS says wireless lan is %s, but the pci device is %s\n",
>  				blocked ? "blocked" : "unblocked",
>  				absent ? "absent" : "present");
> -			pr_warn("skipped wireless hotplug as probably "
> -				"inappropriate for this model\n");
> +			pr_warn("skipped wireless hotplug as probably inappropriate for this model\n");
>  			goto out_unlock;
>  		}
>  
>