linux-kernel - RE: [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB51812066CF2DD4458231F280D97C9@SJ0PR11MB5181.namprd11.prod.outlook.com>
Date:   Tue, 21 Dec 2021 23:22:21 +0000
From:   "Chen, Mike Ximing" <mike.ximing.chen@...el.com>
To:     Joe Perches <joe@...ches.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>
Subject: RE: [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver



> -----Original Message-----
> From: Joe Perches <joe@...ches.com>
> Sent: Tuesday, December 21, 2021 2:00 AM
> To: Chen, Mike Ximing <mike.ximing.chen@...el.com>; linux-kernel@...r.kernel.org
> Cc: arnd@...db.de; gregkh@...uxfoundation.org; Williams, Dan J <dan.j.williams@...el.com>; pierre-
> louis.bossart@...ux.intel.com; netdev@...r.kernel.org; davem@...emloft.net; kuba@...nel.org
> Subject: Re: [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver
> 
> On Tue, 2021-12-21 at 00:50 -0600, Mike Ximing Chen wrote:
> > Add a DLB entry to the MAINTAINERS file.
> 
> btw: Nice documentation
> 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > @@ -9335,6 +9335,13 @@ L:	linux-kernel@...r.kernel.org
> >  S:	Supported
> >  F:	arch/x86/include/asm/intel-family.h
> >
> > +INTEL DYNAMIC LOAD BALANCER DRIVER
> > +M:	Mike Ximing Chen <mike.ximing.chen@...el.com>
> > +S:	Maintained
> > +F:	Documentation/ABI/testing/sysfs-driver-dlb
> > +F:	drivers/misc/dlb/
> > +F:	include/uapi/linux/dlb.h
> > +
> >  INTEL DRM DRIVERS (excluding Poulsbo, Moorestown and derivative chipsets)
> >  M:	Jani Nikula <jani.nikula@...ux.intel.com>
> >  M:	Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>
> 
> Section is not in the appropriate alphabetic order.
> 
> dynamic should be after drm
> 
Thanks. Will fix.

> > diff --git a/drivers/misc/dlb/dlb_main.c b/drivers/misc/dlb/dlb_main.c
> []
> > +// SPDX-License-Identifier: GPL-2.0-only
> []
> > +MODULE_LICENSE("GPL v2");
> 
> Should use "GPL" not "GPL v2".
> 
> https://lore.kernel.org/lkml/alpine.DEB.2.21.1901282105450.1669@nanos.tec.linutronix.de/
> 
We support v2 only.

*      "GPL"                           [GNU Public License v2 or later]
 *      "GPL v2"                        [GNU Public License v2]