linux-kernel - Re: [PATCH v2 1/4] Input: Add driver for Cypress Generation 5 touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKmqyKOtZ5AfVtNPYDNTMUjMRobZUwP7coTgEt94uze35Zxb7Q@mail.gmail.com>
Date:   Wed, 22 Dec 2021 09:28:10 +1000
From:   Alistair Francis <alistair23@...il.com>
To:     Andreas Kemnade <andreas@...nade.info>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Alistair Francis <alistair@...stair23.me>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-input <linux-input@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mylene Josserand <mylene.josserand@...e-electrons.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Henrik Rydberg <rydberg@...math.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mylène Josserand <mylene.josserand@...tlin.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>
Subject: Re: [PATCH v2 1/4] Input: Add driver for Cypress Generation 5 touchscreen

On Sun, Dec 19, 2021 at 8:18 AM Andreas Kemnade <andreas@...nade.info> wrote:
>
> Hi,
>
> On Sun, 12 Dec 2021 21:45:48 -0800
> Dmitry Torokhov <dmitry.torokhov@...il.com> wrote:
>
> [...]
> > > > This is also likely unsafe if controller is not completely shut off and
> > > > is capable of generating interrupts given input device is not yet
> > > > allocated.
> > >
> > > I have dropped the `IRQF_TRIGGER_FALLING |`
> > >
> > > I have tried to use level interrupts, but I can't get the device
> > > working with them.
> >
> > That is weird, does the interrupt controller support level interrupts?
> >
> I have set level interrupts via the devicetree,
> things seem to work on Kobo Clara HD:
> /proc/interrupts
> 203:      37402  gpio-mxc   6 Level     tt21000
>
>        touchscreen@24 {
>                 compatible = "cypress,tt21000";
>                 reg = <0x24>;
>                 pinctrl-names = "default","sleep";
>                 pinctrl-0 = <&pinctrl_cyttsp5_gpio>;
>                 pinctrl-1 = <&pinctrl_cyttsp5_gpio_sleep>;
>                 interrupt-parent = <&gpio5>;
>                 interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
>                 reset-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
>         };

I have tried using IRQ_TYPE_LEVEL_LOW as well, but the device doesn't
start correctly and the commands time out.

It works fine with IRQ_TYPE_EDGE_FALLING though.

Alistair

>
> Regards,
> Andreas