linux-kernel - RE: [PATCH v3] Bluetooth: hci_qca: Stop IBS timer during BT OFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN6PR02MB4094E20A36B022C706929DC18B7C9@SN6PR02MB4094.namprd02.prod.outlook.com>
Date:   Tue, 21 Dec 2021 04:52:05 +0000
From:   "PANICKER HARISH (Temp) (QUIC)" <quic_pharish@...cinc.com>
To:     Matthias Kaehlcke <mka@...omium.org>,
        "PANICKER HARISH (Temp) (QUIC)" <quic_pharish@...cinc.com>
CC:     "marcel@...tmann.org" <marcel@...tmann.org>,
        "johan.hedberg@...il.com" <johan.hedberg@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        "Hemant Gupta (QUIC)" <quic_hemantg@...cinc.com>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        quic_bgodavar <quic_bgodavar@...cinc.com>,
        "rjliao@...eaurora.org" <rjliao@...eaurora.org>,
        "hbandi@...eaurora.org" <hbandi@...eaurora.org>,
        "abhishekpandit@...omium.org" <abhishekpandit@...omium.org>,
        "mcchou@...omium.org" <mcchou@...omium.org>,
        "Sai Teja Aluvala (Temp) (QUIC)" <quic_saluvala@...cinc.com>
Subject: RE: [PATCH v3] Bluetooth: hci_qca: Stop IBS timer during BT OFF



-----Original Message-----
From: Matthias Kaehlcke <mka@...omium.org> 
Sent: Tuesday, December 14, 2021 10:53 PM
To: PANICKER HARISH (Temp) (QUIC) <quic_pharish@...cinc.com>
Cc: marcel@...tmann.org; johan.hedberg@...il.com; linux-kernel@...r.kernel.org; linux-bluetooth@...r.kernel.org; Hemant Gupta (QUIC) <quic_hemantg@...cinc.com>; linux-arm-msm@...r.kernel.org; quic_bgodavar <quic_bgodavar@...cinc.com>; rjliao@...eaurora.org; hbandi@...eaurora.org; abhishekpandit@...omium.org; mcchou@...omium.org; Sai Teja Aluvala (Temp) (QUIC) <quic_saluvala@...cinc.com>
Subject: Re: [PATCH v3] Bluetooth: hci_qca: Stop IBS timer during BT OFF

On Tue, Dec 14, 2021 at 05:54:51PM +0530, Panicker Harish wrote:
> The IBS timers are not stopped properly once BT OFF is triggered.
> we could see IBS commands being sent along with version command, so 
> stopped IBS timers while Bluetooth is off.
> 
> Fixes: 3e4be65eb82c ("Bluetooth: hci_qca: Add poweroff support during 
> hci down for wcn3990")
> 
> Signed-off-by: Panicker Harish <quic_pharish@...cinc.com>
> ---
>  drivers/bluetooth/hci_qca.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c 
> index dd768a8..6f44b26 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1928,6 +1928,9 @@ static int qca_power_off(struct hci_dev *hdev)
>  	hu->hdev->hw_error = NULL;
>  	hu->hdev->cmd_timeout = NULL;
>  
> +	mod_timer(&qca->tx_idle_timer, 0);
> +	mod_timer(&qca->wake_retrans_timer, 0);
> +

If one of the timers is already running it wouldn't be stopped by mod_timer().
I think you want a del_timer_sync() here to ensure the timers aren't running when the chip is powered off.

[Harish] : I will check and update in next patch.