linux-kernel - Re: [PATCH v4] USB: host: isp116x: Check for null res pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YcFxXkn99IOl2L3s@kroah.com>
Date:   Tue, 21 Dec 2021 07:17:02 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     ok@...ecdesign.ee, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] USB: host: isp116x: Check for null res pointer

On Tue, Dec 21, 2021 at 09:56:58AM +0800, Jiasheng Jiang wrote:
> And I correct my commit message because platform_get_resource returns
> null if fails.
> Here is it.
> The return value of platform_get_resource() could be null when there is
> no suitable resource.
> So it should be better to check it to avoid the use of null pointer in
> release_mem_region().
> 
> Fixes: 4808a1c02611 ("[PATCH] USB: Add isp116x-hcd USB host controller driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
> ---
> Changelog:
> 
> v3 -> v4
> 
> *Change 1. Just skip the use of null pointer instead of directly return.
> *Change 2. Add the driver name in the subject line.
> *Change 3. Correct commit message.
> ---
>  drivers/usb/host/isp116x-hcd.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

*plonk*