linux-kernel - Re: [PATCH] arm64: dts: qcom: sdm845: add missing power-controller compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211221065845.GC26872@thinkpad>
Date:   Tue, 21 Dec 2021 12:28:45 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     David Heidelberg <david@...t.cz>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        ~okias/devicetree@...ts.sr.ht, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845: add missing power-controller
 compatible

On Mon, Dec 20, 2021 at 10:14:43PM +0100, David Heidelberg wrote:
> dt-schema expect to have fallback compatible, which is now in-place.
> 
> Fixes warning generated by `make qcom/sdm845-oneplus-fajita.dtb`:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: power-controller@...0000: compatible: ['qcom,sdm845-aoss-qmp'] is too short
>         From schema: Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
> 
> Signed-off-by: David Heidelberg <david@...t.cz>
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 92ab4513a08b..dbdb4243499c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -4619,7 +4619,7 @@ aoss_reset: reset-controller@...0000 {
>  		};
>  
>  		aoss_qmp: power-controller@...0000 {
> -			compatible = "qcom,sdm845-aoss-qmp";
> +			compatible = "qcom,sdm845-aoss-qmp", "qcom,aoss-qmp";

"qcom,sdm845-aoss-qmp" compatible is supported by the driver. So ideally we
don't need a fallback here.

Is this something for DT backwards compatibility?

Thanks,
Mani

>  			reg = <0 0x0c300000 0 0x100000>;
>  			interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>;
>  			mboxes = <&apss_shared 0>;
> -- 
> 2.34.1
>