[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <2becaf314c17f5bff4c6af4a8bd05039dde68497.1639988198.git.yang.guang5@zte.com.cn>
Date: Tue, 21 Dec 2021 08:15:28 +0800
From: davidcomponentone@...il.com
To: zbr@...emap.net
Cc: davidcomponentone@...il.com, gregkh@...uxfoundation.org,
yangyingliang@...wei.com, ivan.zaentsev@...enboard.ru,
yang.guang5@....com.cn, dan.carpenter@...cle.com,
unixbhaskar@...il.com, linux-kernel@...r.kernel.org,
Zeal Robot <zealci@....com.cn>
Subject: [PATCH v3] w1: w1_therm: use swap() to make code cleaner
From: Yang Guang <yang.guang5@....com.cn>
Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.
---
Changes from v1->v2:
- Delete the curly {} braces.
Changes from v2->v3::
- Add --- line before version info.
Reported-by: Zeal Robot <zealci@....com.cn>
Signed-off-by: David Yang <davidcomponentone@...il.com>
Signed-off-by: Yang Guang <yang.guang5@....com.cn>
---
drivers/w1/slaves/w1_therm.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/w1/slaves/w1_therm.c b/drivers/w1/slaves/w1_therm.c
index ca70c5f03206..565578002d79 100644
--- a/drivers/w1/slaves/w1_therm.c
+++ b/drivers/w1/slaves/w1_therm.c
@@ -1785,7 +1785,7 @@ static ssize_t alarms_store(struct device *device,
u8 new_config_register[3]; /* array of data to be written */
int temp, ret;
char *token = NULL;
- s8 tl, th, tt; /* 1 byte per value + temp ring order */
+ s8 tl, th; /* 1 byte per value + temp ring order */
char *p_args, *orig;
p_args = orig = kmalloc(size, GFP_KERNEL);
@@ -1836,9 +1836,8 @@ static ssize_t alarms_store(struct device *device,
th = int_to_short(temp);
/* Reorder if required th and tl */
- if (tl > th) {
- tt = tl; tl = th; th = tt;
- }
+ if (tl > th)
+ swap(tl, th);
/*
* Read the scratchpad to change only the required bits
--
2.30.2
Powered by blists - more mailing lists