linux-kernel - Re: [PATCH] paride: fix up build warning on mips platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Dec 2021 10:23:22 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     tim@...erelk.net, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] paride: fix up build warning on mips platforms

On Mon, Dec 20, 2021 at 09:33:12AM -0700, Jens Axboe wrote:
> On 12/20/21 9:01 AM, Greg Kroah-Hartman wrote:
> > On Tue, Nov 30, 2021 at 09:46:26AM +0100, Greg Kroah-Hartman wrote:
> >> MIPS include files define "PC" so when building the paride driver the
> >> following build warning shows up:
> >>
> >> 	rivers/block/paride/bpck.c:32: warning: "PC" redefined
> >>
> >> Fix this by undefining PC before redefining it as is done for other
> >> defines in this driver.
> >>
> >> Cc: Tim Waugh <tim@...erelk.net>
> >> Cc: Jens Axboe <axboe@...nel.dk>
> >> Cc: linux-block@...r.kernel.org
> >> Cc: linux-kernel@...r.kernel.org
> >> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> >> ---
> >>  drivers/block/paride/bpck.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/block/paride/bpck.c b/drivers/block/paride/bpck.c
> >> index f5f63ca2889d..d880a9465e9b 100644
> >> --- a/drivers/block/paride/bpck.c
> >> +++ b/drivers/block/paride/bpck.c
> >> @@ -28,6 +28,7 @@
> >>  
> >>  #undef r2
> >>  #undef w2
> >> +#undef PC
> >>  
> >>  #define PC			pi->private
> >>  #define r2()			(PC=(in_p(2) & 0xff))
> >> -- 
> >> 2.34.1
> >>
> > 
> > Given the lack of objections to this, I'll just take it through one of
> > my trees for 5.17-rc1.
> 
> Sorry about that, got lost. I can queue it  up too, or you can add my
> acked-by, either is fine.

Easy enough for me to take it, now done, thanks!

greg k-h