linux-kernel - [PATCH] dma: Revert "make dma pool to use kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20211221110724.97664-1-christian.koenig@amd.com>
Date:   Tue, 21 Dec 2021 12:07:24 +0100
From:   "Christian König" 
        <ckoenig.leichtzumerken@...il.com>
To:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, hch@...radead.org
Subject: [PATCH] dma: Revert "make dma pool to use kmalloc_node"

This reverts commit 2618c60b8b5836b73e8deb385a036820744d256d.

While working myself into the dmapool code I've found this little odd
kmalloc_node().

What basically happens here is that we allocate the housekeeping structure
on the numa node where the device is attached to. Since the device is never
doing DMA to or from that memory this doesn't seem to make sense at all.

So while this doesn't seem to cause much harm it's probably cleaner to
revert the change for consistency.

Signed-off-by: Christian König <christian.koenig@....com>
---
 mm/dmapool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/dmapool.c b/mm/dmapool.c
index 64b537b3ccb0..a7eb5d0eb2da 100644
--- a/mm/dmapool.c
+++ b/mm/dmapool.c
@@ -152,7 +152,7 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev,
 	else if ((boundary < size) || (boundary & (boundary - 1)))
 		return NULL;

-	retval = kmalloc_node(sizeof(*retval), GFP_KERNEL, dev_to_node(dev));
+	retval = kmalloc(sizeof(*retval), GFP_KERNEL);
 	if (!retval)
 		return retval;

-- 
2.25.1