linux-kernel - Re: [PATCH] of: unittest: Fix out of bounds array access when id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Dec 2021 07:20:53 -0400
From:   Rob Herring <robh+dt@...nel.org>
To:     Yin Xiujiang <yinxiujiang@...inos.cn>
Cc:     frowand.list@...il.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: unittest: Fix out of bounds array access when id < 0

On Tue, Dec 21, 2021 at 5:34 AM Yin Xiujiang <yinxiujiang@...inos.cn> wrote:
>
> In of_unittest_untrack_overlay if id is less than 0 then
> overlay_id_bits will be out of bounds. And it is also mentioned
> in bugzilla as a bug report:
> https://bugzilla.kernel.org/show_bug.cgi?id=214867
>
> Fix this bug by tiggering WARN_ON()

If id shouldn't be less than 0, can we make it unsigned instead as
discussed here[1].

Rob

[1] https://lore.kernel.org/all/c474a371-b524-1da8-4a67-e72cf8f2b0f7@gmail.com/