linux-kernel - Re: [PATCH] platform/mellanox: mlxbf-pmc: Fix an IS_ERR() vs NULL bug in mlxbf_pmc_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4cedccf8-2ff3-b89f-d6e8-13bad17a86bd@redhat.com>
Date:   Tue, 21 Dec 2021 18:54:31 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Mark Gross <markgross@...nel.org>,
        Vadim Pasternak <vadimp@...dia.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/mellanox: mlxbf-pmc: Fix an IS_ERR() vs NULL bug
 in mlxbf_pmc_map_counters

Hi,

On 12/10/21 08:07, Miaoqian Lin wrote:
> The devm_ioremap() function returns NULL on error, it doesn't return
> error pointers. Also according to doc of device_property_read_u64_array,
> values in info array are properties of device or NULL.
> 
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
>  drivers/platform/mellanox/mlxbf-pmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/mellanox/mlxbf-pmc.c b/drivers/platform/mellanox/mlxbf-pmc.c
> index 04bc3b50aa7a..65b4a819f1bd 100644
> --- a/drivers/platform/mellanox/mlxbf-pmc.c
> +++ b/drivers/platform/mellanox/mlxbf-pmc.c
> @@ -1374,8 +1374,8 @@ static int mlxbf_pmc_map_counters(struct device *dev)
>  		pmc->block[i].counters = info[2];
>  		pmc->block[i].type = info[3];
>  
> -		if (IS_ERR(pmc->block[i].mmio_base))
> -			return PTR_ERR(pmc->block[i].mmio_base);
> +		if (!pmc->block[i].mmio_base)
> +			return -ENOMEM;
>  
>  		ret = mlxbf_pmc_create_groups(dev, i);
>  		if (ret)
>