linux-kernel - Re: [PATCH v2 2/2] ASoC: Add AK4375 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YcIVEgTOuzKRoGdh@sirena.org.uk>
Date:   Tue, 21 Dec 2021 17:55:30 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Vincent Knecht <vincent.knecht@...loo.org>
Cc:     lgirdwood@...il.com, robh+dt@...nel.org, perex@...ex.cz,
        tiwai@...e.com, stephan@...hold.net, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v2 2/2] ASoC: Add AK4375 support

On Mon, Dec 20, 2021 at 08:37:25PM +0100, Vincent Knecht wrote:

> +	SOC_ENUM("DACL Signal Invert", ak4375_invl_enum),
> +	SOC_ENUM("DACR Signal Invert", ak4375_invr_enum),

These should really be a "DAC Signal Invert Switch" control rather than
an enum - really it's an on/off control for inversion.  Other than that
the driver looks good so I'm going to go ahead and apply, please send an
incremental patch fixing this issue.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)