linux-kernel - Re: [PATCH v4] Bluetooth: hci_qca: Stop IBS timer during BT OFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <0B5EAE00-967E-4D53-AC3E-B0182BFB8F80@holtmann.org>
Date:   Wed, 22 Dec 2021 09:33:19 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Panicker Harish <quic_pharish@...cinc.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Matthias Kaehlcke <mka@...omium.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        quic_hemantg@...cinc.com, MSM <linux-arm-msm@...r.kernel.org>,
        quic_bgodavar@...cinc.com, Rocky Liao <rjliao@...eaurora.org>,
        hbandi@...eaurora.org,
        Abhishek Pandit-Subedi <abhishekpandit@...omium.org>,
        Miao-chen Chou <mcchou@...omium.org>, quic_saluvala@...cinc.com
Subject: Re: [PATCH v4] Bluetooth: hci_qca: Stop IBS timer during BT OFF

Hi Panicker,

> The IBS timers are not stopped properly once BT OFF is triggered.
> we could see IBS commands being sent along with version command,
> so stopped IBS timers while Bluetooth is off.
> 
> Fixes: 3e4be65eb82c ("Bluetooth: hci_qca: Add poweroff support during hci down for wcn3990")
> 
> Signed-off-by: Panicker Harish <quic_pharish@...cinc.com>
> ----
> v4:
>  * Used del_timer_sync() instead of mod_timer() to stop the timer and
>    to make sure the handler has finished executing on other CPUs.
> 
> v3:
>  *Addressed reviewers comments
>  *updated commit message
> 
> v2:
>  * Addressed the username
>  * The full implementation of IBS is based on timers
>    to that reason we have used timers.
> 
> v1: initial patch
> ---
> drivers/bluetooth/hci_qca.c | 3 +++
> 1 file changed, 3 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel