linux-kernel - RE: [PATCH v3] Bluetooth: btqca: sequential validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN4PR0201MB8725500D8C41958D3E5F1BA1E37D9@SN4PR0201MB8725.namprd02.prod.outlook.com>
Date:   Wed, 22 Dec 2021 09:18:06 +0000
From:   "Sai Teja Aluvala (Temp) (QUIC)" <quic_saluvala@...cinc.com>
To:     Marcel Holtmann <marcel@...tmann.org>,
        "Sai Teja Aluvala (Temp) (QUIC)" <quic_saluvala@...cinc.com>
CC:     Johan Hedberg <johan.hedberg@...il.com>,
        "mka@...omium.org" <mka@...omium.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        "Hemant Gupta (QUIC)" <quic_hemantg@...cinc.com>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        quic_bgodavar <quic_bgodavar@...cinc.com>,
        "rjliao@...eaurora.org" <rjliao@...eaurora.org>,
        "hbandi@...eaurora.org" <hbandi@...eaurora.org>,
        "abhishekpandit@...omium.org" <abhishekpandit@...omium.org>,
        "mcchou@...omium.org" <mcchou@...omium.org>,
        "PANICKER HARISH (Temp) (QUIC)" <quic_pharish@...cinc.com>
Subject: RE: [PATCH v3] Bluetooth: btqca: sequential validation



-----Original Message-----
From: Marcel Holtmann <marcel@...tmann.org> 
Sent: Friday, December 17, 2021 1:27 AM
To: Sai Teja Aluvala (Temp) (QUIC) <quic_saluvala@...cinc.com>
Cc: Johan Hedberg <johan.hedberg@...il.com>; mka@...omium.org; linux-kernel@...r.kernel.org; linux-bluetooth@...r.kernel.org; Hemant Gupta (QUIC) <quic_hemantg@...cinc.com>; linux-arm-msm@...r.kernel.org; quic_bgodavar <quic_bgodavar@...cinc.com>; rjliao@...eaurora.org; hbandi@...eaurora.org; abhishekpandit@...omium.org; mcchou@...omium.org; PANICKER HARISH (Temp) (QUIC) <quic_pharish@...cinc.com>
Subject: Re: [PATCH v3] Bluetooth: btqca: sequential validation

Hi Sai,

> Added Sequential validation support
> & patch command config
> 
> Signed-off-by: Sai Teja Aluvala <quic_saluvala@...cinc.com>
> 
> v3:
> * removed rlen,rtype
> * Replaced kfree with kfree_skb
> 
> v2:
> * Added static declaration
> * Addressed wrong indentation
> * Removed EDL_PATCH_CONFIG_CMD_LEN
> *
> 
> v1:
> *Initial patch
> ---
> drivers/bluetooth/btqca.c | 48 
> +++++++++++++++++++++++++++++++++++++++++++++++
> drivers/bluetooth/btqca.h |  2 ++
> 2 files changed, 50 insertions(+)
> 
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c 
> index be04d74..21830c6 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -141,6 +141,51 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)
> 	return err;
> }
> 
> +static int qca_send_patch_config_cmd(struct hci_dev *hdev) {
> +	struct sk_buff *skb;
> +	int err = 0;
> +	u8 cmd[] = {EDL_PATCH_CONFIG_CMD, 0x01, 0, 0, 0};

I am going to stop looking at this patch now. You are not able to address review comments.
[Sai] : i missed to update the comments. sorry for overlooking. I will update in next patch.
>From now on, I am only going to review QCA patches from people that are able to handle review comments.

Regards

Marcel