linux-kernel - Re: [PATCH] serial: lantiq: store and compare return status correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Dec 2021 09:38:18 -0400
From:   Rob Herring <robh@...nel.org>
To:     Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Collabora Kernel ML <kernel@...labora.com>
Subject: Re: [PATCH] serial: lantiq: store and compare return status correctly

On Tue, Dec 21, 2021 at 2:42 PM Muhammad Usama Anjum
<usama.anjum@...labora.com> wrote:
>
> platform_get_irq() returns signed status. It should be stored and
> compared as signed value before storing to unsigned variable. Implicit
> conversion from signed to unsigned and then comparison with less than
> zero is wrong as unsigned value can never be less than zero.
>
> Fixes: f087f01ca2 ("serial: lantiq: Use platform_get_irq() to get the interrupt")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
> ---
>  drivers/tty/serial/lantiq.c | 24 ++++++++++++++----------
>  1 file changed, 14 insertions(+), 10 deletions(-)

Thanks for fixing this.

Acked-by: Rob Herring <robh@...nel.org>