linux-kernel - Re: [PATCH v10 04/14] iio: afe: rescale: expose scale processing function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YcKNXaVXrkdgDMTz@shaak>
Date:   Tue, 21 Dec 2021 21:28:45 -0500
From:   Liam Beguin <liambeguin@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     "peda@...ntia.se" <peda@...ntia.se>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
Subject: Re: [PATCH v10 04/14] iio: afe: rescale: expose scale processing
 function

Hi Andy,

On Tue, Dec 21, 2021 at 07:43:52AM +0200, Andy Shevchenko wrote:
> On Tue, Dec 21, 2021 at 7:20 AM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> > On Monday, December 20, 2021, Liam Beguin <liambeguin@...il.com> wrote:
> 
> ...
> 
> >> +               tmp = *val * 1000000000LL;
> >
> > I see this is the original code, but perhaps use proper SI multipliers here and there?
> 
> I mean in a separate change.

Will do!

I'll add a separate patch to convert existing multipliers, and will
fixup the ones I'm adding.

Cheers,
Liam

> >> +               do_div(tmp, 1000000000LL);
> 
> -- 
> With Best Regards,
> Andy Shevchenko