linux-kernel - Re: [PATCH v8 07/14] clk: en7523: Add clock driver for Airoha EN7523 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ae0494f-438e-f147-913f-e0f28eb5b3bf@nbd.name>
Date:   Wed, 22 Dec 2021 16:35:02 +0100
From:   Felix Fietkau <nbd@....name>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        John Crispin <john@...ozen.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>
Subject: Re: [PATCH v8 07/14] clk: en7523: Add clock driver for Airoha EN7523
 SoC

On 2021-12-21 15:06, Arnd Bergmann wrote:
> On Mon, Dec 20, 2021 at 10:18 PM Felix Fietkau <nbd@....name> wrote:
>>
>> This driver only registers fixed rate clocks, since the clocks are fully
>> initialized by the boot loader and should not be changed later, according
>> to Airoha.
>>
>> Signed-off-by: Felix Fietkau <nbd@....name>
> 
> I don't have any particular comments on the driver itself. I'm happy
> to merge it through
> the soc tree for the initial support of the clk maintainers are ok
> with it and have reviewed
> the actual code.
> 
>>  drivers/clk/Kconfig      |   9 +
>>  drivers/clk/Makefile     |   1 +
>>  drivers/clk/clk-en7523.c | 350 +++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 360 insertions(+)
>>  create mode 100644 drivers/clk/clk-en7523.c
> 
> I think this should go into drivers/clk/mediatek, as it probably shares
> some of the logic with the mt762x drivers in there. I'd suggest adding the
> maintainers for those drivers to Cc for additional review.
I don't think it shares any logic with the other drivers, but since 
Airoha is a subsidiary of Mediatek, I guess it makes sense to move it there.

- Felix