linux-kernel - Re: drivers/net/wireless/marvell/mwifiex/pcie.c:659:13: warning: variable 'retval' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87lf0cy6jn.fsf@kernel.org>
Date:   Wed, 22 Dec 2021 17:59:24 +0200
From:   Kalle Valo <kvalo@...nel.org>
To:     kernel test robot <lkp@...el.com>
Cc:     Jonas Dreßler <verdre@...d.nl>,
        kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: drivers/net/wireless/marvell/mwifiex/pcie.c:659:13: warning: variable 'retval' set but not used

+ linux-wireless

kernel test robot <lkp@...el.com> writes:

> Hi Jonas,
>
> FYI, the error/warning still remains.
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   2f47a9a4dfa3674fad19a49b40c5103a9a8e1589
> commit: 8e3e59c31fea5de95ffc52c46f0c562c39f20c59 mwifiex: Try waking the firmware until we get an interrupt
> date:   9 weeks ago
> config: powerpc64-buildonly-randconfig-r005-20211222 (https://download.01.org/0day-ci/archive/20211222/202112222102.0Qk7vOl2-lkp@intel.com/config)
> compiler: powerpc64le-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8e3e59c31fea5de95ffc52c46f0c562c39f20c59
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout 8e3e59c31fea5de95ffc52c46f0c562c39f20c59
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/net/wireless/marvell/mwifiex/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
>
> All warnings (new ones prefixed by >>):
>
>    drivers/net/wireless/marvell/mwifiex/pcie.c: In function 'mwifiex_pm_wakeup_card':
>>> drivers/net/wireless/marvell/mwifiex/pcie.c:659:13: warning: variable 'retval' set but not used [-Wunused-but-set-variable]
>      659 |         int retval;

Jonas, please send a patch fixing this. We are trying to get all W=1
warnings fixed in drivers/net/wireless.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches