linux-kernel - Re: [PATCH] ima: Fix undefined arch_ima_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be59880bb5be18207eeb91b920f43d05fa3a1dd2.camel@linux.ibm.com>
Date:   Wed, 22 Dec 2021 12:10:05 -0500
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Takashi Iwai <tiwai@...e.de>,
        Dmitry Kasatkin <dmitry.kasatkin@...il.com>
Cc:     linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        Joey Lee <jlee@...e.com>
Subject: Re: [PATCH] ima: Fix undefined arch_ima_get_secureboot() and co

Hi Takashi,

On Mon, 2021-12-13 at 17:11 +0100, Takashi Iwai wrote:
> Currently arch_ima_get_secureboot() and arch_get_ima_policy() are
> defined only when CONFIG_IMA is set, and this makes the code calling
> those functions without CONFIG_IMA failing.  Although there is no such
> in-tree users, but the out-of-tree users already hit it.
> 
> Move the declaration and the dummy definition of those functions
> outside ifdef-CONFIG_IMA block for fixing the undefined symbols.
> 
> Signed-off-by: Takashi Iwai <tiwai@...e.de>

Joey's patch has a dependency on your patch, as seen by the kernel test
robot report.  I'll drop the one line referencing in-tree/out-of-tree
sentence in the patch description, before picking it up as well.

thanks,

Mimi