linux-kernel - Re: [PATCH 5/5] dt-bindings: memory: tegra210: Mark EMC as cooling device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YcNeXgRyxvIkcgiD@robh.at.kernel.org>
Date:   Wed, 22 Dec 2021 13:20:30 -0400
From:   Rob Herring <robh@...nel.org>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Jon Hunter <jonathanh@...dia.com>, devicetree@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] dt-bindings: memory: tegra210: Mark EMC as cooling
 device

On Fri, Dec 17, 2021 at 05:59:19PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@...dia.com>
> 
> The external memory controller found on Tegra210 can use throttling of
> the EMC frequency in order to reduce the memory chip temperature. Mark
> the memory controller as a cooling device to take advantage of this
> functionality.
> 
> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
>  .../bindings/memory-controllers/nvidia,tegra210-emc.yaml  | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra210-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra210-emc.yaml
> index bc8477e7ab19..95c14deb8941 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra210-emc.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra210-emc.yaml
> @@ -44,6 +44,11 @@ properties:
>      description:
>        phandle of the memory controller node
>  
> +allOf:
> +  - $ref: ../thermal/thermal-cooling-devices.yaml

/schemas/thermal/...

With that,

Reviewed-by: Rob Herring <robh@...nel.org>

> +
> +unevaluatedProperties: false
> +
>  required:
>    - compatible
>    - reg
> @@ -51,8 +56,6 @@ required:
>    - clock-names
>    - nvidia,memory-controller
>  
> -additionalProperties: false
> -
>  examples:
>    - |
>      #include <dt-bindings/clock/tegra210-car.h>
> @@ -79,4 +82,5 @@ examples:
>          interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
>          memory-region = <&emc_table>;
>          nvidia,memory-controller = <&mc>;
> +        #cooling-cells = <2>;
>      };
> -- 
> 2.34.1
> 
>