[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20211222172923.3209810-1-trix@redhat.com>
Date: Wed, 22 Dec 2021 09:29:23 -0800
From: trix@...hat.com
To: wangzhou1@...ilicon.com, herbert@...dor.apana.org.au,
davem@...emloft.net, nathan@...nel.org, ndesaulniers@...gle.com,
yekai13@...wei.com
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
llvm@...ts.linux.dev, Tom Rix <trix@...hat.com>
Subject: [PATCH v2] crypto: cleanup warning in qm_get_qos_value()
From: Tom Rix <trix@...hat.com>
Building with clang static analysis returns this warning:
qm.c:4382:11: warning: The left operand of '==' is a garbage value
if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
~~~~ ^
The call to qm_qos_value_init() can return an error without setting
*val. So check ret before checking *val.
Fixes: 72b010dc33b9 ("crypto: hisilicon/qm - supports writing QoS int the host")
Signed-off-by: Tom Rix <trix@...hat.com>
---
v2: Add Fixes: line
drivers/crypto/hisilicon/qm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index b1fe9c7b8cc89..c906f2e59277b 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -4379,7 +4379,7 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf,
return -EINVAL;
ret = qm_qos_value_init(val_buf, val);
- if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
+ if (ret || *val == 0 || *val > QM_QOS_MAX_VAL) {
pci_err(qm->pdev, "input qos value is error, please set 1~1000!\n");
return -EINVAL;
}
--
2.26.3
Powered by blists - more mailing lists