linux-kernel - Re: [PATCH] firmware: arm_scmi: replace resevered identifiers in macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Dec 2021 18:15:11 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     trix@...hat.com
Cc:     cristian.marussi@....com, linux-arm-kernel@...ts.infradead.org,
        Sudeep Holla <sudeep.holla@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: arm_scmi: replace resevered identifiers in
 macros

On Wed, Dec 22, 2021 at 09:25:19AM -0800, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> Identifiers starting with __ are resevered.  Replace __X with X.
> 
> The arguments to these macros are pointers.  The macros only reads
> values.  There is no need to make copies of the pointers, use them
> directly.
>

Agreed and thanks for the patch.

However the original patch was modified and these macros were moved
to inline functions[0] after the initial build warnings from the
build bot[1]. Sorry my reply to the bot seems to have got lost and didn't
make it to the list.

-- 
Regards,
Sudeep

[0] https://git.kernel.org/sudeep.holla/c/a690b7e6e7
[1] https://lore.kernel.org/lkml/202112211457.TlWRYcoq-lkp@intel.com/