linux-kernel - Re: [PATCH v11 04/15] iio: afe: rescale: expose scale processing function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YcNscJ/fQhI7h6Uq@shaak>
Date:   Wed, 22 Dec 2021 13:20:32 -0500
From:   Liam Beguin <liambeguin@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Peter Rosin <peda@...ntia.se>, Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v11 04/15] iio: afe: rescale: expose scale processing
 function

Hi Andy,

On Wed, Dec 22, 2021 at 12:21:01PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 22, 2021 at 5:46 AM Liam Beguin <liambeguin@...il.com> wrote:
> >
> > From: Liam Beguin <lvb@...hos.com>
> >
> > In preparation for the addition of kunit tests, expose the logic
> > responsible for combining channel scales.
> 
> ...
> 
> >  #include <linux/gcd.h>
> >  #include <linux/iio/consumer.h>
> >  #include <linux/iio/iio.h>
> > +#include <linux/iio/afe/rescale.h>
> 
> It should go before the consumer.h, no?

I don't mind making the change, but why should it go before consumer.h?

> And I would rather move the entire IIO group of headers...

I can do that too. Do we have a convention for the ordering of #includes?
What's usually the rule/guideline for this?

> >  #include <linux/module.h>
> >  #include <linux/of.h>
> >  #include <linux/of_device.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/property.h>
> 
> ... somewhere here (with blank line above).
> 
> >
> > -struct rescale;
> 
> ...
> 
> > +#ifndef __IIO_RESCALE_H__
> > +#define __IIO_RESCALE_H__
> > +
> > +#include <linux/iio/iio.h>
> 
> Missed types.h and forward declarations like
> struct device;

Okay. will add linux/types.h

Cheers,
Liam

> -- 
> With Best Regards,
> Andy Shevchenko