linux-kernel - Re: [PATCH] schedule: SCHED_RR: Give a fresh time-slice to the task after after it suspends or relinquishes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Dec 2021 02:41:07 +0800
From:   kernel test robot <lkp@...el.com>
To:     "zhaoxiu.zeng" <zhaoxiu.zeng@...il.com>, mingo@...hat.com,
        peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org
Cc:     kbuild-all@...ts.01.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        bristot@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] schedule: SCHED_RR: Give a fresh time-slice to the task
 after after it suspends or relinquishes

Hi "zhaoxiu.zeng",

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on v5.16-rc6 next-20211222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/zhaoxiu-zeng/schedule-SCHED_RR-Give-a-fresh-time-slice-to-the-task-after-after-it-suspends-or-relinquishes/20211222-171838
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 82762d2af31a60081162890983a83499c9c7dd74
config: i386-randconfig-s001-20211222 (https://download.01.org/0day-ci/archive/20211223/202112230234.B6uAyy2x-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/7e5fd85c65d2efc13de4adaa5ebc522894f3d60c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review zhaoxiu-zeng/schedule-SCHED_RR-Give-a-fresh-time-slice-to-the-task-after-after-it-suspends-or-relinquishes/20211222-171838
        git checkout 7e5fd85c65d2efc13de4adaa5ebc522894f3d60c
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash kernel/sched/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
   kernel/sched/rt.c:924:70: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/rt.c:924:70: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/rt.c:924:70: sparse:    struct task_struct *
   kernel/sched/rt.c:1010:38: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct task_struct *curr @@     got struct task_struct [noderef] __rcu *curr @@
   kernel/sched/rt.c:1010:38: sparse:     expected struct task_struct *curr
   kernel/sched/rt.c:1010:38: sparse:     got struct task_struct [noderef] __rcu *curr
>> kernel/sched/rt.c:1560:35: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct task_struct *p @@     got struct task_struct [noderef] __rcu *curr @@
   kernel/sched/rt.c:1560:35: sparse:     expected struct task_struct *p
   kernel/sched/rt.c:1560:35: sparse:     got struct task_struct [noderef] __rcu *curr
   kernel/sched/rt.c: note: in included file:
   kernel/sched/sched.h:2032:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:2032:25: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:2032:25: sparse:    struct task_struct *
   kernel/sched/sched.h:2032:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:2032:25: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:2032:25: sparse:    struct task_struct *
   kernel/sched/sched.h:2032:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:2032:25: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:2032:25: sparse:    struct task_struct *

vim +1560 kernel/sched/rt.c

  1557	
  1558	static void yield_task_rt(struct rq *rq)
  1559	{
> 1560		struct task_struct *p = rq->curr;
  1561	
  1562		if (p->policy == SCHED_RR)
  1563			p->rt.time_slice = sched_rr_timeslice;
  1564	
  1565		requeue_task_rt(rq, p, 0);
  1566	}
  1567	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org