linux-kernel - Re: [PATCH v16 08/40] gpu: host1x: Add initial runtime PM and OPP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <796eb3f7-80e2-bc55-fd52-43e76220f8c2@nvidia.com>
Date:   Wed, 22 Dec 2021 19:30:05 +0000
From:   Jon Hunter <jonathanh@...dia.com>
To:     Dmitry Osipenko <digetx@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Viresh Kumar <vireshk@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Mikko Perttunen <mperttunen@...dia.com>,
        Lee Jones <lee.jones@...aro.org>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Nishanth Menon <nm@...com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Michael Turquette <mturquette@...libre.com>
Cc:     linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-pwm@...r.kernel.org,
        linux-mmc@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-clk@...r.kernel.org, David Heidelberg <david@...t.cz>
Subject: Re: [PATCH v16 08/40] gpu: host1x: Add initial runtime PM and OPP
 support


On 22/12/2021 19:01, Dmitry Osipenko wrote:

...

> diff --git a/drivers/gpu/host1x/syncpt.c b/drivers/gpu/host1x/syncpt.c
> index e08e331e46ae..8194826c9ce3 100644
> --- a/drivers/gpu/host1x/syncpt.c
> +++ b/drivers/gpu/host1x/syncpt.c
> @@ -137,6 +137,15 @@ void host1x_syncpt_restore(struct host1x *host)
>   	struct host1x_syncpt *sp_base = host->syncpt;
>   	unsigned int i;
> 
> +	for (i = 0; i < host->info->nb_pts; i++) {
> +		/*
> +		 * Unassign syncpt from channels for purposes of Tegra186
> +		 * syncpoint protection. This prevents any channel from
> +		 * accessing it until it is reassigned.
> +		 */
> +		host1x_hw_syncpt_assign_to_channel(host, sp_base + i, NULL);
> +	}
> +
>   	for (i = 0; i < host1x_syncpt_nb_pts(host); i++)
>   		host1x_hw_syncpt_restore(host, sp_base + i);
> 
> @@ -352,13 +361,6 @@ int host1x_syncpt_init(struct host1x *host)
>   	for (i = 0; i < host->info->nb_pts; i++) {
>   		syncpt[i].id = i;
>   		syncpt[i].host = host;
> -
> -		/*
> -		 * Unassign syncpt from channels for purposes of Tegra186
> -		 * syncpoint protection. This prevents any channel from
> -		 * accessing it until it is reassigned.
> -		 */
> -		host1x_hw_syncpt_assign_to_channel(host, &syncpt[i], NULL);
>   	}
> 
>   	for (i = 0; i < host->info->nb_bases; i++)
> 


Thanks! This fixed it!

Jon

-- 
nvpublic